fix: define fallback GFLAGS_NS=google in config headers and remove the need of passing the -DGFLAGS_NS=google flags#2878
Closed
chenrui333 wants to merge 2 commits into
Closed
fix: define fallback GFLAGS_NS=google in config headers and remove the need of passing the -DGFLAGS_NS=google flags#2878chenrui333 wants to merge 2 commits into
GFLAGS_NS=google in config headers and remove the need of passing the -DGFLAGS_NS=google flags#2878chenrui333 wants to merge 2 commits into
Conversation
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Author
|
relates to #2877 |
Contributor
|
In my opinion, it is better to use GFLAGS_NAMESPACE instead of GFLAGS_NS. |
Contributor
|
The issue has been fixed in in #2877 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
seeing some regression build failure in Homebrew/homebrew-core#204308
It would be just better to define
GFLAGS_NS=googlein config headersWhat is changed and the side effects?
Changed:
Side effects:
Performance effects(性能影响):
Breaking backward compatibility(向后兼容性):
Check List: